fix: Write Off not working when paid_amount is greater than grand_total #43303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devdiogenes
requested review from
deepeshgarg007,
rohitwaghchaure and
ruthra-kumar
as code owners
github-actions
bot
added
accounts
needs-tests
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
Waiting review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write-Off amount is currently not working when the paid amount is greater than the grand_total.
To simulate, lets suppose that we're selling an item that costs $ 8.50, then we only give back $ 1.00 to the customer, and the customer says that we don't need to give back the $ 0.50 amount.
Item value: $ 8.50
Change amount: $ 1.00
Write-off: $ -0.50
This is how the system behaves before apply changes:
This commit apply all changes necessary for make it works properly. This is how the system behaves after applying changes:
I also changed POS Invoice Merge Log, cause after we make the POS Closing Entry, the write-off amounts are not summed in the consolidated Sales Invoice.